[Groonga-commit] groonga/fluent-plugin-groonga at bfcf4bd [fluentd-v0.12] test out: use more meaningful test names

Back to archive index

Yasuhiro Horimoto null+****@clear*****
Tue Jan 16 12:17:39 JST 2018


Yasuhiro Horimoto	2018-01-16 12:17:39 +0900 (Tue, 16 Jan 2018)

  New Revision: bfcf4bd1e55ff3a9cda038f4e31924658627c924
  https://github.com/groonga/fluent-plugin-groonga/commit/bfcf4bd1e55ff3a9cda038f4e31924658627c924

  Merged 638bad8: Merge pull request #26 from komainu8/fluentd-v0.12

  Message:
    test out: use more meaningful test names

  Modified files:
    test/test_output.rb

  Modified: test/test_output.rb (+14 -6)
===================================================================
--- test/test_output.rb    2018-01-16 12:08:22 +0900 (3c7d50a)
+++ test/test_output.rb    2018-01-16 12:17:39 +0900 (b9aaa9a)
@@ -96,7 +96,7 @@ EOC
     end
 
     class CommandTest < self
-      def test_basic_command
+      def test_command_name_position_tag
         @response_body = JSON.generate([[0, 0.0, 0.0], true])
         driver = create_driver("groonga.command.table_create")
         time = Time.parse("2012-10-26T08:45:42Z").to_i
@@ -106,11 +106,16 @@ EOC
                      @request_parser.request_url)
       end
 
-      def test_basic_command_with_command_format_record
+      def test_command_name_position_record
         @response_body = JSON.generate([[0, 0.0, 0.0], true])
         driver = create_driver("groonga.command")
         time = Time.parse("2012-10-26T08:45:42Z").to_i
-        driver.emit({"name" => "table_create", "arguments" => {"name" => "Users"}}, time)
+        driver.emit({
+                      "name" => "table_create",
+                      "arguments" => {
+                        "name" => "Users"
+                      }
+                    }, time)
         driver.run
         assert_equal("/d/table_create?name=Users",
                      @request_parser.request_url)
@@ -238,7 +243,7 @@ EOC
     end
 
     class CommandTest < self
-      def test_basic_command
+      def test_command_name_position_tag
         driver = create_driver("groonga.command.table_create")
         time = Time.parse("2012-10-26T08:45:42Z").to_i
         driver.emit({"name" => "Users"}, time)
@@ -257,10 +262,13 @@ EOC
                      ])
       end
 
-      def test_basic_command_with_command_format_record
+      def test_command_name_position_record
         driver = create_driver("groonga.command")
         time = Time.parse("2012-10-26T08:45:42Z").to_i
-        driver.emit({"name" => "table_create", "arguments" => {"name" => "Users"}}, time)
+        driver.emit({
+                      "name" => "table_create",
+                      "arguments" => {"name" => "Users"}
+                    }, time)
         driver.run
         assert_equal([
                        [
-------------- next part --------------
HTML����������������������������...
URL: https://lists.osdn.me/mailman/archives/groonga-commit/attachments/20180116/c322174a/attachment-0003.htm 



More information about the Groonga-commit mailing list
Back to archive index