[logaling-commit] logaling/logalimacs [master] Fix unnecessary the with for loop macro

Back to archive index

null+****@clear***** null+****@clear*****
Mon Feb 27 12:58:31 JST 2012


yuta yamada	2012-02-27 12:58:31 +0900 (Mon, 27 Feb 2012)

  New Revision: 9ea3b0d296388854d0863948a1519222c6a70955

  Log:
    Fix unnecessary the with for loop macro

  Modified files:
    logalimacs.el

  Modified: logalimacs.el (+12 -14)
===================================================================
--- logalimacs.el    2012-02-27 12:53:00 +0900 (8587c82)
+++ logalimacs.el    2012-02-27 12:58:31 +0900 (954fecb)
@@ -233,20 +233,18 @@
     record))
 
 (defun loga-max-length (words)
-  (loop
-   with max-source-length = 0
-   with max-target-length = 0
-   with source-length
-   with target-length
-   for (source target) in words do
-   (setq source-length (loga-decide-length source)
-         target-length (loga-decide-length target))
-   if (and (< max-source-length source-length)
-           (< source-length loga-width-limit-source)
-           (loga-less-than-half-p source-length target-length))
-   collect (setq max-source-length source-length
-                 max-target-length (max max-target-length target-length))
-   finally (setq loga-current-max-length (cons max-source-length max-target-length))))
+  (let* ((max-source-length 0)
+         (max-target-length 0)
+         source-length target-length)
+    (loop for (source target) in words do
+          (setq source-length (loga-decide-length source)
+                target-length (loga-decide-length target))
+          if (and (< max-source-length source-length)
+                  (< source-length loga-width-limit-source)
+                  (loga-less-than-half-p source-length target-length))
+          collect (setq max-source-length source-length
+                        max-target-length (max max-target-length target-length))
+          finally (setq loga-current-max-length (cons max-source-length max-target-length)))))
 
 (defun loga-less-than-half-p (source-length target-length)
   (let* ((half (- (/ (window-width) 2) 2)))




More information about the logaling-commit mailing list
Back to archive index