On 06/01/19 16:22, Eli Zaretskii wrote: >> However, __USE_MINGW_FSEEK is another feature test macro which >> really shouldn't be visible outside of MinGW.org source code, and >> the case for not deprecating it is even weaker ... how many of >> those projects which abuse it actually deliver Win9x compatible >> code today, anyway? > > Well, we do want MinGW Binutils to work on Windows 9X, don't we? Yes, but from a user's POV, it seems more logical to me to say "Hey, MinGW-GCC, give me the best level of support you can, all the way back to Win95", not "Hey, MinGW-GCC, I'd like you to enable this obscure feature which is among several which I think may possibly be needed on Win95". >> Those that do should *really* be defining _WIN32_WINDOWS, which >> implicitly enables the __USE_MINGW_FSEEK feature. > > My problem with _WIN32_WINDOWS is that it appears in a dozen places in > our w32api headers, and just analyzing its impact is a serious job. > By contrast, __USE_MINGW_FSEEK is a much more focused knob. More focused, yes; *too* focused maybe ... as a user, I have to know in advance, that it enables a feature that I will almost certainly need, if I want my application to work correctly on Win95, and I also need to think about any other such features I may need. OTOH, with -D_WIN32_WINDOWS=_WIN32_WINDOWS_95 I can cover all bases at once. -- Regards, Keith. Public key available from keys.gnupg.net Key fingerprint: C19E C018 1547 DE50 E1D4 8F53 C0AD 36C6 347E 5A3F -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: OpenPGP digital signature URL: <https://lists.osdn.me/mailman/archives/mingw-users/attachments/20190109/7efeed1c/attachment.sig>
Fork