Commit: d9afeaf60ce8f05acadb512b9b60689858440dbb - zandronum-tspg (hg)

This is a fork of Zandronum used on servers hosted by The Sentinels Playground (TSPG).

Commit MetaInfo

• Revision: d9afeaf60ce8f05acadb512b9b60689858440dbb (tree)
• Time: 2022-01-24 07:29:50
• Author: Edoardo Prezioso <edward.san.dev@gmai...>
• Commiter: Edoardo Prezioso

Log Message

Fix a crash with the Hexen Firestorm weapon projectiles caused by a compiler misoptimization on Linux architecture.

Change Summary

• modified: src/g_hexen/a_clericflame.cpp

Incremental Difference

diff -r 452ac11f0e16 -r d9afeaf60ce8 src/g_hexen/a_clericflame.cpp
--- a/src/g_hexen/a_clericflame.cpp	Fri Feb 04 09:57:33 2022 -0500
+++ b/src/g_hexen/a_clericflame.cpp	Sun Jan 23 23:29:50 2022 +0100
@@ -120,8 +120,9 @@
 
 DEFINE_ACTION_FUNCTION(AActor, A_CFlameMissile)
 {
-	int i;
-	int an, an90;
+	// [EP] Fix misoptimization, not needed in recent GZDoom
+	unsigned int i;
+	unsigned int an;
 	fixed_t dist;
 	AActor *mo;
 	
@@ -141,7 +142,8 @@
 		for (i = 0; i < 4; i++)
 		{
 			an = (i*ANG45)>>ANGLETOFINESHIFT;
-			an90 = (i*ANG45+ANG90)>>ANGLETOFINESHIFT;
+			// [EP] Remove unused variable, will be removed also in GZDoom
+			// an90 = (i*ANG45+ANG90)>>ANGLETOFINESHIFT;
 			mo = Spawn ("CircleFlame", BlockingMobj->x+FixedMul(dist, finecosine[an]),
 				BlockingMobj->y+FixedMul(dist, finesine[an]), 
 				BlockingMobj->z+5*FRACUNIT, ALLOW_REPLACE);