Commit: 919383ac718c2a3187ee2a9ad659daa22da26258 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: 919383ac718c2a3187ee2a9ad659daa22da26258 (tree)
• Time: 2017-04-26 05:10:53
• Author: Maciej W. Rozycki <macro@imgt...>
• Commiter: Maciej W. Rozycki

Log Message

MIPS/readelf: Remove extraneous null GOT data check

Null data is handled gracefully throughout in MIPS GOT processing, with
addresses printed normally and unavailable data shown as <unknown>' by
print_mips_got_entry', and special processing code for GOT[1] doing an
explicit check. Remove an unwanted null GOT data check then, introduced
with commit 592458412fb2 in the course of addressing PR binutils/12855.

binutils/
* readelf.c (process_mips_specific): Remove null GOT data check.

Change Summary

• modified: binutils/ChangeLog
• modified: binutils/readelf.c

Incremental Difference

--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,5 +1,9 @@
 2017-04-25  Maciej W. Rozycki  <[e-mail]>
 
+	* readelf.c (process_mips_specific): Remove null GOT data check.
+
[phone]  Maciej W. Rozycki  <[e-mail]>
+
 	* testsuite/binutils-all/mips/mips16-alias.d: New test.
 	* testsuite/binutils-all/mips/mips16-noalias.d: New test.
 	* testsuite/binutils-all/mips/mips16-alias.s: New test source.

--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -15483,8 +15483,7 @@ process_mips_specific (FILE * file)
       data = (unsigned char *) get_data (NULL, file, offset,
                                          global_end - pltgot, 1,
 					 _("Global Offset Table data"));
-      if (data == NULL)
-	return FALSE;
+      /* PR 12855: Null data is handled gracefully throughout.  */
       data_end = data + (global_end - pltgot);
 
       printf (_("\nPrimary GOT:\n"));