Commit: a8c4c3829b0f867890150dec379ca0e8281d0ca1 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: a8c4c3829b0f867890150dec379ca0e8281d0ca1 (tree)
• Time: 2003-06-14 08:18:30
• Author: Jim Blandy <jimb@code...>
• Commiter: Jim Blandy

Log Message

* gdbarch.sh (gdbarch_bfd_entry_point): New gdbarch method.
* arch-utils.c (generic_bfd_entry_point): New function.
* arch-utils.h (generic_bfd_entry_point): New declaration.
* gdbarch.c, gdbarch.h: Regenerated.
* solib-svr4.c (enable_break): Call it, instead of accessing
tmp_bfd->start_address directly.

Change Summary

• modified: gdb/ChangeLog
• modified: gdb/arch-utils.c
• modified: gdb/arch-utils.h
• modified: gdb/gdbarch.c
• modified: gdb/gdbarch.h
• modified: gdb/gdbarch.sh
• modified: gdb/solib-svr4.c

Incremental Difference

--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
 2003-06-13  Jim Blandy  <[e-mail]>
 
+	* gdbarch.sh (gdbarch_bfd_entry_point): New gdbarch method.
+	* arch-utils.c (generic_bfd_entry_point): New function.
+	* arch-utils.h (generic_bfd_entry_point): New declaration.
+	* gdbarch.c, gdbarch.h: Regenerated.
+	* solib-svr4.c (enable_break): Call it, instead of accessing
+	tmp_bfd->start_address directly.
+
 	* ppc-linux-tdep.c (ppc64_linux_convert_from_func_ptr_addr): New
 	function.
 	(ppc_linux_init_abi): Register it as the

--- a/gdb/arch-utils.c
+++ b/gdb/arch-utils.c
@@ -368,6 +368,12 @@ cannot_register_not (int regnum)
   return 0;
 }
 
+CORE_ADDR
+generic_bfd_entry_point (struct gdbarch *gdbarch, bfd *abfd)
+{
+  return bfd_get_start_address (abfd);
+}
+
 /* Legacy version of target_virtual_frame_pointer().  Assumes that
    there is an DEPRECATED_FP_REGNUM and that it is the same, cooked or
    raw.  */

--- a/gdb/arch-utils.h
+++ b/gdb/arch-utils.h
@@ -81,6 +81,10 @@ extern int core_addr_greaterthan (CORE_ADDR lhs, CORE_ADDR rhs);
 extern const struct floatformat *default_float_format (struct gdbarch *gdbarch);
 extern const struct floatformat *default_double_format (struct gdbarch *gdbarch);
 
+/* Return the start address of ABFD.  This is exactly like
+   bfd_get_start_address, except that it's a gdbarch function.  */
+extern CORE_ADDR generic_bfd_entry_point (struct gdbarch *gdbarch, bfd *abfd);
+
 /* The following DEPRECATED interfaces are for pre- multi-arch legacy
    targets. */
 

--- a/gdb/gdbarch.c
+++ b/gdb/gdbarch.c
@@ -264,6 +264,7 @@ struct gdbarch
   gdbarch_software_single_step_ftype *software_single_step;
   gdbarch_print_insn_ftype *print_insn;
   gdbarch_skip_trampoline_code_ftype *skip_trampoline_code;
+  gdbarch_bfd_entry_point_ftype *bfd_entry_point;
   gdbarch_in_solib_call_trampoline_ftype *in_solib_call_trampoline;
   gdbarch_in_solib_return_trampoline_ftype *in_solib_return_trampoline;
   gdbarch_pc_in_sigtramp_ftype *pc_in_sigtramp;
@@ -432,6 +433,7 @@ struct gdbarch startup_gdbarch =
   0,  /* software_single_step */
   0,  /* print_insn */
   0,  /* skip_trampoline_code */
+  generic_bfd_entry_point,  /* bfd_entry_point */
   0,  /* in_solib_call_trampoline */
   0,  /* in_solib_return_trampoline */
   0,  /* pc_in_sigtramp */
@@ -557,6 +559,7 @@ gdbarch_alloc (const struct gdbarch_info *info,
   current_gdbarch->smash_text_address = core_addr_identity;
   current_gdbarch->print_insn = legacy_print_insn;
   current_gdbarch->skip_trampoline_code = generic_skip_trampoline_code;
+  current_gdbarch->bfd_entry_point = generic_bfd_entry_point;
   current_gdbarch->in_solib_call_trampoline = generic_in_solib_call_trampoline;
   current_gdbarch->in_solib_return_trampoline = generic_in_solib_return_trampoline;
   current_gdbarch->pc_in_sigtramp = legacy_pc_in_sigtramp;
@@ -746,6 +749,7 @@ verify_gdbarch (struct gdbarch *gdbarch)
   /* Skip verify of software_single_step, has predicate */
   /* Skip verify of print_insn, invalid_p == 0 */
   /* Skip verify of skip_trampoline_code, invalid_p == 0 */
+  /* Skip verify of bfd_entry_point, invalid_p == 0 */
   /* Skip verify of in_solib_call_trampoline, invalid_p == 0 */
   /* Skip verify of in_solib_return_trampoline, invalid_p == 0 */
   /* Skip verify of pc_in_sigtramp, invalid_p == 0 */
@@ -790,6 +794,10 @@ gdbarch_dump (struct gdbarch *gdbarch, struct ui_file *file)
                       GDB_MULTI_ARCH);
   if (GDB_MULTI_ARCH)
     fprintf_unfiltered (file,
+                        "gdbarch_dump: bfd_entry_point = 0x%08lx\n",
+                        (long) current_gdbarch->bfd_entry_point);
+  if (GDB_MULTI_ARCH)
+    fprintf_unfiltered (file,
                         "gdbarch_dump: gdbarch_frame_align_p() = %d\n",
                         gdbarch_frame_align_p (current_gdbarch));
   if (GDB_MULTI_ARCH)
@@ -5436,6 +5444,25 @@ set_gdbarch_skip_trampoline_code (struct gdbarch *gdbarch,
   gdbarch->skip_trampoline_code = skip_trampoline_code;
 }
 
+CORE_ADDR
+gdbarch_bfd_entry_point (struct gdbarch *gdbarch, bfd *abfd)
+{
+  gdb_assert (gdbarch != NULL);
+  if (gdbarch->bfd_entry_point == 0)
+    internal_error (__FILE__, __LINE__,
+                    "gdbarch: gdbarch_bfd_entry_point invalid");
+  if (gdbarch_debug >= 2)
+    fprintf_unfiltered (gdb_stdlog, "gdbarch_bfd_entry_point called\n");
+  return gdbarch->bfd_entry_point (gdbarch, abfd);
+}
+
+void
+set_gdbarch_bfd_entry_point (struct gdbarch *gdbarch,
+                             gdbarch_bfd_entry_point_ftype bfd_entry_point)
+{
+  gdbarch->bfd_entry_point = bfd_entry_point;
+}
+
 int
 gdbarch_in_solib_call_trampoline (struct gdbarch *gdbarch, CORE_ADDR pc, char *name)
 {

--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -2699,6 +2699,20 @@ extern void set_gdbarch_skip_trampoline_code (struct gdbarch *gdbarch, gdbarch_s
 #define SKIP_TRAMPOLINE_CODE(pc) (gdbarch_skip_trampoline_code (current_gdbarch, pc))
 #endif
 
+/* The actual instruction address at which ABFD would begin execution.
+   If ABFD is position-independent code, this address is not relocated;
+   it's the address at which execution would begin if the file were
+   loaded at its sections' vmas.
+  
+   On most architectures, this is simply bfd_get_start_address.  But on
+   some (like 64-bit PPC), that points to a function descriptor, not an
+   instruction.  The descriptor contains the actual entry point, and
+   other pointers needed to call the function. */
+
+typedef CORE_ADDR (gdbarch_bfd_entry_point_ftype) (struct gdbarch *gdbarch, bfd *abfd);
+extern CORE_ADDR gdbarch_bfd_entry_point (struct gdbarch *gdbarch, bfd *abfd);
+extern void set_gdbarch_bfd_entry_point (struct gdbarch *gdbarch, gdbarch_bfd_entry_point_ftype *bfd_entry_point);
+
 /* For SVR4 shared libraries, each call goes through a small piece of
    trampoline code in the ".plt" section.  IN_SOLIB_CALL_TRAMPOLINE evaluates
    to nonzero if we are currently stopped in one of these. */

--- a/gdb/gdbarch.sh
+++ b/gdb/gdbarch.sh
@@ -666,6 +666,16 @@ F:2:SOFTWARE_SINGLE_STEP:void:software_single_step:enum target_signal sig, int i
 f:2:TARGET_PRINT_INSN:int:print_insn:bfd_vma vma, disassemble_info *info:vma, info:::legacy_print_insn::0
 f:2:SKIP_TRAMPOLINE_CODE:CORE_ADDR:skip_trampoline_code:CORE_ADDR pc:pc:::generic_skip_trampoline_code::0
 
+# The actual instruction address at which ABFD would begin execution.
+# If ABFD is position-independent code, this address is not relocated;
+# it's the address at which execution would begin if the file were
+# loaded at its sections' vmas.
+# 
+# On most architectures, this is simply bfd_get_start_address.  But on
+# some (like 64-bit PPC), that points to a function descriptor, not an
+# instruction.  The descriptor contains the actual entry point, and
+# other pointers needed to call the function.
+m:1::CORE_ADDR:bfd_entry_point:bfd *abfd:abfd:::generic_bfd_entry_point::0
 
 # For SVR4 shared libraries, each call goes through a small piece of
 # trampoline code in the ".plt" section.  IN_SOLIB_CALL_TRAMPOLINE evaluates

--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -1036,7 +1036,8 @@ enable_break (void)
 	 the current pc (which should point at the entry point for the
 	 dynamic linker) and subtracting the offset of the entry point.  */
       if (!load_addr_found)
-	load_addr = read_pc () - tmp_bfd->start_address;
+	load_addr = (read_pc ()
+                     - gdbarch_bfd_entry_point (current_gdbarch, tmp_bfd));
 
       /* Record the relocated start and end address of the dynamic linker
          text and plt section for svr4_in_dynsym_resolve_code.  */