Commit: ca3f923f82a079dcf441419f4a50a50f8b4b33c2 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: ca3f923f82a079dcf441419f4a50a50f8b4b33c2 (tree)
• Time: 2020-04-17 10:26:01
• Author: Alan Modra <amodra@gmai...>
• Commiter: Alan Modra

Log Message

PR25840, Null pointer dereference in objdump

PR 25840
* debug.c (debug_class_type_samep): Don't segfault on NULL type.

Change Summary

• modified: binutils/ChangeLog
• modified: binutils/debug.c

Incremental Difference

--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
[phone]  Alan Modra  <[e-mail]>
+
+	PR 25840
+	* debug.c (debug_class_type_samep): Don't segfault on NULL type.
+
 2020-04-16  Alan Modra  <[e-mail]>
 
 	* doc/binutils.texi: Mention --no-show-raw-insn in objdump

--- a/binutils/debug.c
+++ b/binutils/debug.c
@@ -3277,6 +3277,8 @@ debug_class_type_samep (struct debug_handle *info, struct debug_type_s *t1,
              names, since that sometimes fails in the presence of
              typedefs and we really don't care.  */
 	  if (strcmp (f1->name, f2->name) != 0
+	      || f1->type == NULL
+	      || f2->type == NULL
 	      || ! debug_type_samep (info,
 				     debug_get_real_type ((void *) info,
 							  f1->type, NULL),