Commit: 3a3c37d49e419fb584cf8f53b4cc511987256180 - dia (git)

作図ソフト dia の改良版

Commit MetaInfo

• Revision: 3a3c37d49e419fb584cf8f53b4cc511987256180 (tree)
• Time: 2014-10-02 07:14:41
• Author: Hans Breuer <hans@breu...>
• Commiter: Hans Breuer

Log Message

[warningectomy] format string is not a string literal (potentially insecure)

plug-ins.c:234:51: warning: format string is not a string literal (potentially insecure) [-Wformat-security]

message(_("%s Plugin could not be unloaded"), info->name);

^~

Change Summary

• modified: lib/plug-ins.c

Incremental Difference

--- a/lib/plug-ins.c
+++ b/lib/plug-ins.c
@@ -231,7 +231,8 @@ dia_plugin_unload(PluginInfo *info)
     return;
 
   if (!dia_plugin_can_unload(info)) {
-    message(_("%s Plugin could not be unloaded"), info->name);
+    /* calling this function w/o check first is a programmer's error */
+    g_warning ("%s plugin could not be unloaded", info->name);
     return;
   }
   /* perform plugin cleanup */