dia_improved

Fork

Bug 737254 - Use AC_CONFIG_HEADERS instead of AC_CONFIG_HEADER

Could not find any documentation for the later, we can not use
AM_CONFIG_HEADER long time deprecated, finally gone.

[warningectomy] unused const variable

node.c:58:21: warning: unused variable 'NODE_BORDERWIDTH'
[-Wunused-const-variable]
static const double NODE_BORDERWIDTH = 0.1;
^
node.c:60:21: warning: unused variable 'NODE_FONTHEIGHT'
[-Wunused-const-variable]
static const double NODE_FONTHEIGHT = 0.8;
^
2 warnings generated.

[unit test] check bounding box calculation vs. path drawing

The use of DiaPathRenderer in _test_draw() is now hidden behind a call to
create_standard_path_from_object(). This way the 'bounds' of the drawing
can be measured indirectly.
Convert to path is supposed to create an equivalent representation which
should produce the same (or smaller) bounding box as the original object.

The exception list is currently pretty long, so there is definitely room
for improvement. With smaller default tolerance value the list would be
much longer. And finally it would be nice to not only check if the bounding
box is big enough, but also if is close to what's really needed. But this
initial version should help catching regressions already.

[transform] svg: more transformation support for Standard objects

New optional method DiaObject::transform() to apply an affine transformation
to the object. Immediately visible effect - without SVG - is rotation support
for 'Standard - Box' and 'Standard - Ellipse'.
'Standard - Text' and 'Standard - Image' are not fully supported yet, because
they require significant work on the renderer level.
Standard - Arc, Outline and ZigZagLine are not included because they wont be
used from SVG and the direct support is considered pointless.

Currently the intended main use-case is improved transformation from SVG
especially on the level of single elements. The included test file
transform-variations.svg shows the issues solved and open.

Cosmetic update of PyDiaObjects.dia

[cleanup] remove superfluous prototype and comment

Updated Indonesian translation

Updated Czech translation

Updated Spanish Translation

Updated Norwegian bokmål translation.

[warningectomy] No previous prototype (missing static)

../../lib/prop_pixbuf.c:200:1: warning: no previous prototype for '_make_pixbuf_type_name' [-Wmissing-prototypes]
_make_pixbuf_type_name (const char *p)
^

[warningectomy] Remove unused variable

Bug 737255 - don't mess with localedir

According to Pacho Ramos https://bugzilla.gnome.org/show_bug.cgi?id=737255

[gtk-deprecated] Fix endless loop with grid stepping

commit 5a788e5ebe93b72a787319d1204f72ebb9aabd0a introduced a potential
endless loop with grid_step() and DiaRuler to "compensate for missing
5 and 6 in 3,4,..,7,8 major ticks". The rounding problem can be solved
more correctly with ROUND(), rather than potentially doing the same
step over and over again.

[unit test] various improvements to test-objects

- fix typos and misleading comments
- prefer g_assert_cmpfloat() over g_assert() because it gives more
information on failure
- remove most of the filtered objects from _test_movement() now that
another bounding box miscalculation is gone
- check if reversed DiaObject::move_handle() is restoring the original
object bounding box (as it should)

[unit test] add more bounding box tests

which helped debugging the recent fix

Fix DiaColorSelector via 'More...' to not destroy the wrong widget

transform: Fix Group::move_handle() to only move the desired handles

DiaObject::move_handle() method has some constraints, i.e it must be
reversible by moving back exactly that handle to the previous position.
To accomplish this restrict the minimum size of the transformed group
and calculate a matrix to keep the opposite handle position fixed.

Also rename array Group::resize_handles to just Group::handles.

path: Fix limit checking of StdPath::move_handle()

The path object must not get too small, otherwise it can not be
restored by reverse move_handle. So implement a minimum distance
between the moving and the opposite handle.
This way undo can restore the object by just moving back the
handle to it's previous position.

path: Implement Flip horizontal/vertical for 'Standard - Path' object

Flip horizontal/vertical like custom objects do, except that this
function is modifying the underlying point data. This function is
available with the context menu of the 'Standard - Path' object.

path: Fix bezier bounding box calculation glitches

Without a 'pointy join' there is no point in calculating the overshot,
actually this was growing the bounding box arbitrarily. (First line
of bezier-extreme.dia)

Also handle slightly degenerated bezier where the control point and
the start or end point are in the same place. Now we are using the
other control point to have a direction for add_arrow_rectangle()
in bicubicbezier2D_bbox(). Otherwise there would be no bounding box
contribution from line ends of this kind (see second line of
bezier-extreme.dia)

Having this fix also seems to be a precondition for properly behaving
StdPath::move_handle(). Previously, e.g. with commit 14e05d51d99e1457
it was possible to go over the constraints implemented, presumably
due to bounding box miscalculations leading to wrong handle positions.

Still with line-join round the bezier is drawn a bit outside of the box.

path: make handle behavior equivalent to other objects

Shear and Rotate are now available via context menu.

move_handle() is supposed to be just moving that and related handles (e.g.
when N is moved NE and NW will move too). But 'opposite' handles are not
to be moved at all. So our transformation is invariant to the opposite
point of the path, not the object position.

text: improve cursor positioning via mouse

the click had to be completely after the glyph, now the right half
of the glyph is enough

NEWS: mention render improvements and gradients

image: fix 'Standard - Image' set_props() for pixbuf changes

- switch on inline data => make inline: set pixbuf, keep filename
- switch off inline data => save pixbuf to filename, if new filename
- set a new, non empty filename => load the file
- set an empty filename => make inline
- set a new, non NULL pixbuf => use as image, inline

Also provide a test file and an updated uninline_data.py script.

image: remember mime-type from pixbuf loading to use it when saving

more efficient storage when working with embedded jpeg, for images in dia
native files as well as with SVG. Also optimize away a string copy of the
base64 encoding.

Bug 680688 - disable most top menu items when there is no display

there was almost everything needed with display_actions, just some common_entries
not to be included for the integrated UI case, otherwise we could not load a
diagram or quit anymore.

pat-variations.svg: more paths with holes

cleanup: remove DiaObject::flags, add remove DiaObjectType::flags

The only object flag is a type property (parenting is object type specific).
There is no way to change it after construction and there must not be. This
reduces the size of DiaObject to 96 (32 bit OS) and just needs one
indirection per object_flags_set() call.
Also remove unused DIA_OBJECT_GRABS_CHILD_INPUT - another leftover from
the unfinished "new group" stuff.

tests>test-sizeof

DiaObject: 96
Connection: 224
Element: 392
UMLClass: 952
Handle: 32
ConnectionPoint: 32

dox: documentation update for DiaObject member functions