Commit: 22b21a067414d43c97df1212a0d5f0c42371818e - mmw_serv (git)

Commit MetaInfo

• Revision: 22b21a067414d43c97df1212a0d5f0c42371818e (tree)
• Time: 2017-07-31 20:06:17
• Author: HMML <hmml3939@gmai...>
• Commiter: HMML

Log Message

Implement VERY simple forecast API.

Change Summary

• add: app/assets/javascripts/api/v1/forecasts.coffee
• add: app/assets/stylesheets/api/v1/forecasts.scss
• add: app/controllers/api/v1/forecasts_controller.rb
• add: app/helpers/api/v1/forecasts_helper.rb
• modified: app/models/area.rb
• add: app/views/api/v1/forecasts/show.html.haml
• add: app/views/api/v1/forecasts/show.json.jbuilder
• modified: config/routes.rb
• add: db/migrate/20170731101544_add_time_zone_to_area.rb
• add: db/migrate/20170731102841_add_ns_code_index_on_area.rb
• modified: db/schema.rb
• add: spec/controllers/api/v1/forecasts_controller_spec.rb

Incremental Difference

--- /dev/null
+++ b/app/assets/javascripts/api/v1/forecasts.coffee
@@ -0,0 +1,3 @@
+# Place all the behaviors and hooks related to the matching controller here.
+# All this logic will automatically be available in application.js.
+# You can use CoffeeScript in this file: http://coffeescript.org/

--- /dev/null
+++ b/app/assets/stylesheets/api/v1/forecasts.scss
@@ -0,0 +1,3 @@
+// Place all the styles related to the Api::V1::Forecasts controller here.
+// They will automatically be included in application.css.
+// You can use Sass (SCSS) here: http://sass-lang.com/

--- /dev/null
+++ b/app/controllers/api/v1/forecasts_controller.rb
@@ -0,0 +1,17 @@
+class Api::V1::ForecastsController < ApplicationController
+  respond_to :json
+  before_action :set_target
+
+  def show
+    @area.timezone? and
+      Time.zone = @area.timezone
+    respond_with @area
+  end
+
+  private
+  def set_target
+    @area = Area.find_by!(ns: params.require(:area_ns), code: params.require(:area_code))
+    now = Time.now
+    @forecasts = @area.forecasts.where('date >= ? and date <= ?', now, now + 1.day)
+  end
+end

--- /dev/null
+++ b/app/helpers/api/v1/forecasts_helper.rb
@@ -0,0 +1,2 @@
+module Api::V1::ForecastsHelper
+end

--- a/app/models/area.rb
+++ b/app/models/area.rb
@@ -1,3 +1,8 @@
 class Area < ApplicationRecord
   has_many :forecasts
+
+  def utc_offset
+    timezone? or return nil
+    ActiveSupport::TimeZone[timezone].utc_offset
+  end
 end

--- /dev/null
+++ b/app/views/api/v1/forecasts/show.html.haml
@@ -0,0 +1,2 @@
+%h1 Api::V1::Forecasts#show
+%p Find me in app/views/api/v1/forecasts/show.html.haml

--- /dev/null
+++ b/app/views/api/v1/forecasts/show.json.jbuilder
@@ -0,0 +1,6 @@
+reported_at = nil
[e-mail] {|f| f.reported_at.to_i > reported_at.to_i and reported_at = f.reported_at }
+
+json.extract! @area, :ns, :code, :country, :pref, :name, :updated_at, :timezone, :utc_offset
+json.reported_at reported_at
+json.daily_forecasts @forecasts, :weather_symbol, :weather_label, :date, :reported_at, :temp_min, :temp_max, :pop

--- a/config/routes.rb
+++ b/config/routes.rb
@@ -1,11 +1,17 @@
 Rails.application.routes.draw do
+  namespace :api, defaults: {format: :json}  do
+    namespace :v1 do
+      get ':area_ns/:area_code', to: 'forecasts#show'
+    end
+  end
+
   devise_for :users
-  resources :users
-  resources :forecasts
-  resources :areas
+
   get  'sub', to: 'subscribe#verify'
   post 'sub', to: 'subscribe#distribute'
-
+  resources :users, only: %i(index show)
+  resources :forecasts, only: %i(index show)
+  resources :areas, only: %i(index show)
   resources :dist_signals, only: %i(index show)
 
   root 'dummy_error_controller#index'

--- /dev/null
+++ b/db/migrate/20170731101544_add_time_zone_to_area.rb
@@ -0,0 +1,6 @@
+class AddTimeZoneToArea < ActiveRecord::Migration[5.1]
+  def change
+    add_column :areas, :timezone, :string
+    execute "UPDATE areas SET timezone = 'Asia/Tokyo' WHERE country = 'ja'"
+  end
+end

--- /dev/null
+++ b/db/migrate/20170731102841_add_ns_code_index_on_area.rb
@@ -0,0 +1,5 @@
+class AddNsCodeIndexOnArea < ActiveRecord::Migration[5.1]
+  def change
+    add_index :areas, [:ns, :code], unique: true
+  end
+end

--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20170724142504) do
+ActiveRecord::Schema.define(version: 20170731102841) do
 
   create_table "areas", force: :cascade do |t|
     t.string "ns"
@@ -20,6 +20,8 @@ ActiveRecord::Schema.define(version: 20170724142504) do
     t.string "name"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
+    t.string "timezone"
+    t.index ["ns", "code"], name: "index_areas_on_ns_and_code", unique: true
   end
 
   create_table "delayed_jobs", force: :cascade do |t|

--- /dev/null
+++ b/spec/controllers/api/v1/forecasts_controller_spec.rb
@@ -0,0 +1,12 @@
+require 'rails_helper'
+
+RSpec.describe Api::V1::ForecastsController, type: :controller do
+
+  describe "GET #show" do
+    it "returns http success" do
+      get :show
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+end