Commit: 5dfd774994b4f0f92ce7319021d03219392741f8 - KancolleSniffer (git)

Commit MetaInfo

• Revision: 5dfd774994b4f0f92ce7319021d03219392741f8 (tree)
• Time: 2020-09-26 02:07:28
• Author: Kazuhiro Fujieda <fujieda@user...>
• Commiter: Kazuhiro Fujieda

Log Message

SGレーダー(初期型)の装備ボーナスを索敵スコアの計算から除く

Change Summary

• modified: KancolleSniffer.Test/SnifferTest.cs
• modified: KancolleSniffer.Test/logs
• modified: KancolleSniffer.sln.DotSettings
• modified: KancolleSniffer/Model/Fleet.cs
• modified: KancolleSniffer/Model/ItemSpec.cs
• modified: KancolleSniffer/Model/ItemStatus.cs
• modified: KancolleSniffer/Model/ShipMaster.cs
• modified: KancolleSniffer/Model/ShipSpec.cs
• modified: KancolleSniffer/Model/ShipStatus.cs

Incremental Difference

--- a/KancolleSniffer.Test/SnifferTest.cs
+++ b/KancolleSniffer.Test/SnifferTest.cs
@@ -233,6 +233,18 @@ namespace KancolleSniffer.Test
         }
 
         /// <summary>
+        /// SGレーダー(初期型)の装備ボーナスを外して索敵スコアを計算する
+        /// </summary>
+        [TestMethod]
+        public void LineOfSightWithSgRadar()
+        {
+            var sniffer = new Sniffer();
+            SniffLogFile(sniffer, "lineofsight_004");
+            var fleet = sniffer.Fleets[0];
+            PAssert.That(() => Abs(fleet.GetLineOfSights(1) - 0.93) < 0.01);
+        }
+
+        /// <summary>
         /// 触接開始率を正しく計算する
         /// </summary>
         [TestMethod]

--- a/KancolleSniffer.Test/logs
+++ b/KancolleSniffer.Test/logs
@@ -1 +1 @@
-Subproject commit 7877795d0035744d2fba262aac91245267b5bd8b
+Subproject commit 57340ec2ceb0ccd27c8f548bc67320e901dd68f2

--- a/KancolleSniffer.sln.DotSettings
+++ b/KancolleSniffer.sln.DotSettings
@@ -56,4 +56,5 @@
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Scrollify/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Seiran/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=taiha/@EntryIndexedValue">True</s:Boolean>
-	<s:Boolean x:Key="/Default/UserDictionary/Words/=Truncator/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=Truncator/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=Yomi/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>

--- a/KancolleSniffer/Model/Fleet.cs
+++ b/KancolleSniffer/Model/Fleet.cs
@@ -216,20 +216,10 @@ namespace KancolleSniffer.Model
 
         public double GetLineOfSights(int factor)
         {
-            var result = 0.0;
-            var emptyBonus = 6;
-            foreach (var s in ActualShips.Where(s => !s.Escaped))
-            {
-                emptyBonus--;
-                var itemLoS = 0;
-                foreach (var item in s.AllSlot)
-                {
-                    var spec = item.Spec;
-                    itemLoS += spec.LoS;
-                    result += (spec.LoS + item.LoSLevelBonus) * spec.LoSScaleFactor * factor;
-                }
-                result += Sqrt(s.LoS - itemLoS);
-            }
+            var actual = ActualShips.Where(s => !s.Escaped).ToArray();
+            var emptyBonus = 6 - actual.Length;
+            var result = actual.Sum(s =>
+                s.AllSlot.Sum(item => item.EffectiveLoS * factor) + Sqrt(s.RawLoS));
             return result > 0 ? result - Ceiling(_getHqLevel() * 0.4) + emptyBonus * 2 : 0.0;
         }
 

--- a/KancolleSniffer/Model/ItemSpec.cs
+++ b/KancolleSniffer/Model/ItemSpec.cs
@@ -82,6 +82,8 @@ namespace KancolleSniffer.Model
             }
         }
 
+        public int LoSSgRadarBonus => Id == 315 ? 4 : 0;
+
         public bool IsAircraft
         {
             get

--- a/KancolleSniffer/Model/ItemStatus.cs
+++ b/KancolleSniffer/Model/ItemStatus.cs
@@ -134,7 +134,9 @@ namespace KancolleSniffer.Model
             }
         }
 
-        public double LoSLevelBonus
+        public double EffectiveLoS => (Spec.LoS + LoSLevelBonus) * Spec.LoSScaleFactor;
+
+        private double LoSLevelBonus
         {
             get
             {

--- a/KancolleSniffer/Model/ShipMaster.cs
+++ b/KancolleSniffer/Model/ShipMaster.cs
@@ -39,6 +39,7 @@ namespace KancolleSniffer.Model
                     Id = (int)entry.api_id,
                     SortId = entry.api_sort_id() ? (int)entry.api_sort_id : 0,
                     Name = ShipName(entry),
+                    Yomi = entry.api_yomi,
                     FuelMax = entry.api_fuel_max() ? (int)entry.api_fuel_max : 0,
                     BullMax = entry.api_bull_max() ? (int)entry.api_bull_max : 0,
                     SlotNum = (int)entry.api_slot_num,

--- a/KancolleSniffer/Model/ShipSpec.cs
+++ b/KancolleSniffer/Model/ShipSpec.cs
@@ -21,6 +21,7 @@ namespace KancolleSniffer.Model
         public int Id { get; set; }
         public int SortId { get; set; }
         public string Name { get; set; }
+        public string Yomi { get; set; }
         public int FuelMax { get; set; }
         public int BullMax { get; set; }
         public int SlotNum { get; set; }
@@ -149,5 +150,31 @@ namespace KancolleSniffer.Model
         public bool IsRepairShip => ShipType == 19;
 
         public bool IsTrainingCruiser => ShipType == 21;
+
+        public bool HaveSgRadarBonus
+        {
+            get
+            {
+                switch (Yomi)
+                {
+                    case "フレッチャー":
+                    case "ジョンストン":
+                    case "サミュエル・B・ロバーツ":
+                    case "コロラド":
+                    case "サウスダコタ":
+                    case "アイオワ":
+                    case "サラトガ":
+                    case "ホーネット":
+                    case "イントレピッド":
+                    case "ガンビア・ベイ":
+                    case "ヒューストン":
+                    case "ヘレナ":
+                    case "アトランタ":
+                        return true;
+                    default:
+                        return false;
+                }
+            }
+        }
     }
 }
\ No newline at end of file

--- a/KancolleSniffer/Model/ShipStatus.cs
+++ b/KancolleSniffer/Model/ShipStatus.cs
@@ -417,6 +417,9 @@ namespace KancolleSniffer.Model
 
         public int EffectiveBullMax => Max((int)(Spec.BullMax * (Level >= 100 ? 0.85 : 1.0)), 1);
 
+        public int RawLoS =>
+            LoS - AllSlot.Sum(item => item.Spec.LoS + (Spec.HaveSgRadarBonus ? item.Spec.LoSSgRadarBonus : 0));
+
         public object Clone()
         {
             var r = (ShipStatus)MemberwiseClone();