Commit: a0cd4411904e248223a922ff454d6f09d959861b - frameworks-av (git)

frameworks/av

Commit MetaInfo

• Revision: a0cd4411904e248223a922ff454d6f09d959861b (tree)
• Time: 2020-04-14 22:49:59
• Author: Paulo Sergio Travaglia <pstglia@gmai...>
• Commiter: Chih-Wei Huang

Log Message

Allow screenrecord usage on Android-x86

Selects a supported color format for screenrecord (
OMX_COLOR_FormatYUV420Planar instead of OMX_COLOR_FormatAndroidOpaque)
and removes a check on SoftVideoEncoderOMXComponent.cpp
in order to make screenrecord work on Android-x86.

Change Summary

• modified: cmds/screenrecord/screenrecord.cpp
• modified: media/libstagefright/omx/SoftVideoEncoderOMXComponent.cpp

Incremental Difference

--- a/cmds/screenrecord/screenrecord.cpp
+++ b/cmds/screenrecord/screenrecord.cpp
@@ -187,7 +187,7 @@ static status_t prepareEncoder(float displayFps, sp<MediaCodec>* pCodec,
     format->setInt32(KEY_WIDTH, gVideoWidth);
     format->setInt32(KEY_HEIGHT, gVideoHeight);
     format->setString(KEY_MIME, kMimeTypeAvc);
-    format->setInt32(KEY_COLOR_FORMAT, OMX_COLOR_FormatAndroidOpaque);
+    format->setInt32(KEY_COLOR_FORMAT, OMX_COLOR_FormatYUV420Planar);
     format->setInt32(KEY_BIT_RATE, gBitRate);
     format->setFloat(KEY_FRAME_RATE, displayFps);
     format->setInt32(KEY_I_FRAME_INTERVAL, 10);

--- a/media/libstagefright/omx/SoftVideoEncoderOMXComponent.cpp
+++ b/media/libstagefright/omx/SoftVideoEncoderOMXComponent.cpp
@@ -397,8 +397,10 @@ OMX_ERRORTYPE SoftVideoEncoderOMXComponent::internalGetParameter(
             // XXX: For now just configure input and output buffers the same size.
             // May want to determine a more suitable output buffer size independent
             // of YUV format.
+#if !defined(__i386__) && !defined(__x86_64__)
             CHECK(mColorFormat == OMX_COLOR_FormatYUV420Planar ||
                     mColorFormat == OMX_COLOR_FormatYUV420SemiPlanar);
+#endif
             def->nBufferSize = mWidth * mHeight * 3 / 2;
 
             return OMX_ErrorNone;