@cazfi: Can you look on my patch?
Reply To lachu
@cazfi: Can you look on my patch?
Yea, I try to get closer to winter time work habits during this weekend, if not yet to full steam.
- Just handle the packet in packhand.c like all the others, no point in creating new module for a single packet (there would be a point to split packhand.c a bit, but then we should do it for some bigger group)
- I don't see you adding 'num_counters' to ruleset_control, though you try to validate it on packet receive
- Function headers missing for the new functions
Reply To cazfi
- Just handle the packet in packhand.c like all the others, no point in creating new module for a single packet (there would be a point to split packhand.c a bit, but then we should do it for some bigger group)
...
- Function headers missing for the new functions
Any progress with this?
Reply To cazfi
Reply To cazfi
- Just handle the packet in packhand.c like all the others, no point in creating new module for a single packet (there would be a point to split packhand.c a bit, but then we should do it for some bigger group)
...
- Function headers missing for the new functions
Any progress with this?
Aughhh..... Sory.. I miss some of your comment. I must address three problems yet.
Reply To cazfi
- Just handle the packet in packhand.c like all the others, no point in creating new module for a single packet (there would be a point to split packhand.c a bit, but then we should do it for some bigger group)
Done. I will publish patch later.
- I don't see you adding 'num_counters' to ruleset_control, though you try to validate it on packet receive
I added it into: PACKET_RULESET_CONTROL = 155; sc, lsend
- Function headers missing for the new functions
I must check, what do you mean. There is client_counter.h file. I known, it should be called client_counters.h
2022-09-08 01:14 Updated by: lachu File 0001-OSND-41123-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10270) is attached
Moved client-related function around counter and network handling into packhand.c
Reply To [comment:12505:41123:63885
- I don't see you adding 'num_counters' to ruleset_control, though you try to validate it on packet receive[[
Ok. I added num_counters to control packet in other patch: 5d85fc89fdaaead8ad7bb3f6835d206bc3fd3208 . What do now?
Reply To lachu
2022-09-08 01:14 Updated by: lachu File 0001-OSND-41123-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10270) is attached
Moved client-related function around counter and network handling into packhand.c
- client/Makefile.am still refers to those removed source files, causing build to fail in lack of them
- Space before ";" in "packet.checkpoint = pcount->checkpoint ;"
- For counter_target and counter_behavior enum definitions in fc_types.h, now part of network protocol, add the standard "/* Used in the network protocol. */" -comment
Reply To cazfi
Reply To lachu
2022-09-08 01:14 Updated by: lachu File 0001-OSND-41123-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10270) is attached
Moved client-related function around counter and network handling into packhand.c
- client/Makefile.am still refers to those removed source files, causing build to fail in lack of them
- Space before ";" in "packet.checkpoint = pcount->checkpoint ;"
- For counter_target and counter_behavior enum definitions in fc_types.h, now part of network protocol, add the standard "/* Used in the network protocol. */" -comment
Done.
Introduce a new network packet containing ruleset information about one counter. Send these packets to client when rulesets have been loaded.