Ticket #43388

Lua: Replace listenv() with nef's fce()

Open Date: 2021-12-12 06:21 Last Update: 2021-12-25 16:51

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
4

Details

In http://forum.freeciv.org/f/viewtopic.php?f=14&t=91972&p=103953#p103947 nef lists ways that current listenv() may hang or crash, and provides a function called fce() as a replacement.

Port nef's fce() to mainstream freeciv. Replace current listenv() implementation with a trivial wrapper for fce() (to keep function named listenv() around for compatibility)

Ticket History (3/10 Histories)

2021-12-12 06:21 Updated by: cazfi
  • New Ticket "Lua: Replace listenv() with nef's fce()" created
2021-12-12 06:35 Updated by: cazfi
  • Resolution Update from None to Accepted
2021-12-12 07:46 Updated by: cazfi
Comment

I think we can have this even in d3f S3_0, after all; just remove old listenv(), bring in fce() named as listenv() and modified to have same fingerprint as old listenv() had. Then it would be, compatibility wise, drop-in replacement.

2021-12-12 07:51 Updated by: cazfi
  • Resolution Update from None to Accepted
2021-12-21 03:39 Updated by: cazfi
Comment

New patch version based on new fce() version by nef

2021-12-25 16:51 Updated by: cazfi
  • Status Update from Open to Closed
  • Owner Update from (None) to cazfi
  • Resolution Update from Accepted to Fixed

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login