Ticket #44877

Cease-fire not recorded to max_state as higher state than War

Open Date: 2022-06-20 19:18 Last Update: 2022-07-07 06:16

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

Diplstate max_state remain War when the players first agree on Cease-fire. It seems wrong, but it might be that we shouldn't have such a "transitional" state recorded as the max_state - entering Armistice is recorded as Peace to max_state.

Ticket History (3/4 Histories)

2022-06-20 19:18 Updated by: cazfi
  • New Ticket "Cease-fire not recorded to max_state as higher state than War" created
2022-06-30 08:23 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
  • Milestone Update from (None) to 3.2.0
Comment

Reply To cazfi

but it might be that we shouldn't have such a "transitional" state recorded as the max_state

If there's problems with that, we should resolve them in master. As a general rule, we should have accurate max_state in 3.2.

Patch for the cease-fire attached.

2022-07-07 06:16 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login