OSDN -- Develop and Download Open Source Software

Ticket #45890
Ticket List Submit New Ticket RSS

Make PACKET_CITY_UPDATE_COUNTER is-game-info

Open Date: 2022-10-17 20:12 Last Update: 2023-01-09 14:22

Reporter:
cazfi
Owner:
cazfi
Type:
Patches
Status:
Closed
Component:
General
MileStone:
3.2.0
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
3

Details

Give PACKET_CITY_UPDATE_COUNTER 'is-game-info' flag for the delta protocol to know it's ok to not sent the packet at all when there's no changes.

Maybe packet should also be renamed as PACKET_CITY_COUNTER_INFO for consistency with other packets with similar semantics?

Ticket History (3/10 Histories)

2022-10-17 20:12 Updated by: cazfi
  • New Ticket "Make PACKET_CITY_UPDATE_COUNTER is-game-info" created
2022-11-01 17:08 Updated by: lachu
Comment

Reply To cazfi

Give PACKET_CITY_UPDATE_COUNTER 'is-game-info' flag for the delta protocol to know it's ok to not sent the packet at all when there's no changes. Maybe packet should also be renamed as PACKET_CITY_COUNTER_INFO for consistency with other packets with similar semantics?

Done.

2022-11-21 10:13 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
2022-11-23 06:04 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed
2023-01-04 01:19 Updated by: lachu
Comment

2023-01-04 01:18 Updated by: lachu

File 0001-Add-is-game-info-flag-to-PACKET_CITY_UPDATE_COUNTER.patch (File ID: 11297) is attached

Probably I done bad think, because we should never change history. If it would be recommended, I will prepare separated patch. You talk about opening a new ticket in other thread.

2023-01-04 01:28 Updated by: lachu
Comment

Reply To cazfi

Give PACKET_CITY_UPDATE_COUNTER 'is-game-info' flag for the delta protocol to know it's ok to not sent the packet at all when there's no changes. Maybe packet should also be renamed as PACKET_CITY_COUNTER_INFO for consistency with other packets with similar semantics?

Two new patches are send. Second is to apply on HEAD. First is to rewrite history, which probably is not what should be done. I do not set message, because you probably open a new ticket, so alter message as you wish.

2023-01-09 14:22 Updated by: cazfi
Comment

Reply To lachu

because you probably open a new ticket

Is #46496 the ticket you expected? If you need something else, just open it yourself.

Attachment File List

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login