Ticket #46186

packhand.c "pcity->client.collecting_info_units_supported != NULL" failures

Open Date: 2022-12-04 18:23 Last Update: 2023-05-15 06:33

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
4

Details

Observing an S3_0 HEAD + 3.0.5 targeted patches autogame there's packhand.c "pcity->client.collecting_info_units_supported != NULL" assert failures (and similar ones for "..._present")

Likely related to the fact that I'm observing single player.

Ticket History (3/12 Histories)

2022-12-04 18:23 Updated by: cazfi
  • New Ticket "packhand.c "pcity->client.collecting_info_units_supported != NULL" failures" created
2022-12-04 21:08 Updated by: cazfi
2023-02-03 02:04 Updated by: cazfi
2023-04-07 13:03 Updated by: cazfi
2023-05-10 12:08 Updated by: cazfi
Comment

pcity->client.collecting_info_units_supported is created only for controlling connection, as it depends on request id from packet_processing_started.

2023-05-10 12:54 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
  • Component Update from (None) to General
Comment

Patches for all branches, including S2_6.

main/S3_2 get mandatory network protocol change, npf branches optional one.

2023-05-14 14:52 Updated by: cazfi
Comment

On S3_0 and S3_1 this leaves the case where new client connects to old server a bit unsatisfactory. But as there's no regression there (only that the fix does not apply to all cases it could), and it's too late to rework this before 3.1.0-beta2, leaving that part to a new ticket -> #48046

2023-05-15 06:33 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login