Ticket #48109

CI: mac-meson build failing (-Wtautological-pointer-compare) mapview_common.c

Open Date: 2023-05-30 16:40 Last Update: 2023-05-30 18:29

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
8
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

mac-meson CI build is giving -Wtautological-pointer-compare:

../client/mapview_common.c:1914:7: error: comparison of nonnull parameter 'width' not equal to a null pointer is 'true' on first encounter [-Werror,-Wtautological-pointer-compare]
  if (width != NULL) {
      ^~~~~    ~~~~
../client/mapview_common.c:90:18: note: declared 'nonnull' here
  fc__attribute((nonnull(5, 6)));
                 ^
../client/mapview_common.c:1917:7: error: comparison of nonnull parameter 'height' not equal to a null pointer is 'true' on first encounter [-Werror,-Wtautological-pointer-compare]
  if (height != NULL) {
      ^~~~~~    ~~~~
../client/mapview_common.c:90:18: note: declared 'nonnull' here
  fc__attribute((nonnull(5, 6)));
                 ^
2 errors generated.

Ticket History (3/4 Histories)

2023-05-30 16:40 Updated by: cazfi
  • New Ticket "CI: mac-meson build failing (-Wtautological-pointer-compare) mapview_common.c" created
2023-05-30 18:27 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
Comment

Patch to be pushed in immediately.

2023-05-30 18:29 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login