Ticket #48127

Savegame: "unused entry" warnings about treaty.accept

Open Date: 2023-06-01 09:45 Last Update: 2023-06-07 05:12

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
3

Details

Seen & investigated on S3_0: Loading a savegame sometimes gives "unused entry" warnings about "accept0" and "accept1" entries of treaties.

The treaties in question seem to be ones with no clauses added (or the clauses removed). The bug seems to be that "accept0" and "accept1" are read *inside the loop of reading clauses*. I guess that in most cases this results in multiple checks of treaty acceptance (once for each clause), but in case of zero clauses it's not checked at all.

Ticket History (3/6 Histories)

2023-06-01 09:45 Updated by: cazfi
  • New Ticket "Savegame: "unused entry" warnings about treaty.accept" created
2023-06-01 09:52 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
Comment

Patches for all branches, including S2_6.

2023-06-07 05:12 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login