#42193: dai_calc_data() income calculation does not include immediately spent part
Open Date: 2021-05-07 12:47
Last Update: 2021-07-09 08:45
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/42193
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42193
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2021-07-09 08:45 Updated by: cazfi
* Status Update from Open to Closed
* Owner Update from (None) to cazfi
* Resolution Update from Accepted to Fixed
Comment:
Reply To cazfi
Reply To chippo
It applies cleanly to S3_0. Can I expect it to do anything on it's own?
There should be a slight improvement to overall AI performance, but you would need to apply statistical methods to see them - variations between individual games are bigger than effects of the bug fixed. With civ2civ3 #42191 might override any improved calculation correctness, so you would need to use e.g. classic ruleset.
Actually, it might show up as AI having lower tax rate. It uses income calculated by dai_calc_data() when deciding how high tax rate it needs for a balanced budget.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 2.6.6
Component: AI
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
dai_calc_data() counts only 'surplus' as income, not including what's being immediately spent. Expenses are correctly calculated. So in perfect balance 'income' is returned as zero, and expenses as some high number. Callers then think that expenses > income.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/42193
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42193