#46172: Move counter initialization routine outside ruleset initialization code, so ruledit could use it
Open Date: 2022-12-03 18:08
Last Update: 2022-12-06 04:53
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/46172
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46172
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-12-06 04:53 Updated by: cazfi
* Type Update from Feature Requests to Patches
* Priority Update from 4 to 5 - Medium
Comment:
+ pcounter->ruledit_disabled = false;
Should be FALSE in freeciv C-code (we can use false in C++)
--
+#include <stdbool.h>
Include (utility/)support.h for getting bool defined by portable way (even when there's no stdbool.h header in the system)
---------------------------------------------------------------------
Ticket Status:
Reporter: lachu
Owner: cazfi
Type: Patches
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: (None)
Component: Ruledit and ruleup
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Currently, counter initialization code is placed inside ruleset loading code. This makes sense in past, because there was no other parts, which would use it. Currently, ruledit need to reinitialize and initialize counters, what means ruledit_enable is set to default value, name struct was free/reinitialized, etc.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/46172
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46172