#44754: Fatal tileset load failure not handled in FREECIV_NDEBUG build
Open Date: 2022-06-04 20:44
Last Update: 2022-06-20 19:49
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44754
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44754
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-06-20 19:49 Updated by: cazfi
Comment:
Plan to push to S2_6 too, for easing work of anybody porting it to more exotic environments.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.3
Component: Client common
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
tilespec_reread() has
fc_assert_exit_msg(NULL != tileset, "Failed to re-read the currently loaded tileset.");
On FREECIV_NDEBUG builds it does not give the error message from that assert, but likely crashes in a more mysterious way. Also; clang analyzer gives warnings about those later dereferences of the NULL tileset (which is how I found this).
We should not use fc_assert there, but handle the situation also in FREECIV_NDEBUG builds.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44754
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44754