#45631: can_player_build_unit_direct() double is_barbarian() call
Open Date: 2022-09-10 03:41
Last Update: 2022-10-06 01:18
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45631
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45631
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-10-06 01:18 Updated by: cazfi
* Owner Update from (None) to cazfi
* Resolution Update from None to Accepted
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.2.0
Component: General
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
can_player_build_unit_direct() does 'barbarian = is_barbarian(p)" assignment twice (in the beginning, and a bit later. It's already needed before the latter one). As it's a function call, compiler even cannot leave one out.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45631
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45631