#45541: pick_random_tech_to_lose() compile error
Open Date: 2022-09-01 02:45
Last Update: 2022-10-09 05:30
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45541
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45541
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-10-09 05:30 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 3.0.5
Component: General
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
I've got a compile error from pick_random_tech_to_lose() on a meson based build with -Doptimization=3, and gcc-12.
This looks somewhat familiar. Likely this is what we resolved with #42885 for the autotools side. What I didn't realize at the time autotools failure was being investigated is that advance_count(); is not called ONLY within the iterator macro, but pick_random_tech_to_lose() calls it also before the iteration. That's another reason for the compiler to be worried about its return values.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45541
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45541