#45889: Send initial counter values to client Open Date: 2022-10-17 14:08 Last Update: 2023-06-28 16:44 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/45889 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45889 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2023-06-28 16:44 Updated by: cazfi Comment: Reply To lachu Reply To cazfi Reply To lachu which is not related to this ticket Err.. is some patch here one that should solve this ticket? I use git branch --contains commit_id which commit id gathered via git log. Everything is in place currently. Just response if you need more generic way. EDIT: There you are clarification was goes wrong and why I messed up in this ticket. I was fought with bug described in this post: 2023-03-13 01:46 Updated by: lachu . But, as I wrote, every patch, with should makes everything worked, was applied to main. There's nothing pushed in addressing this issue, and it's easy to produce a failing case. ---- - Add these to civ2civ3: Counter to game.ruleset [counter_owned] name = "Owned 5 Turns" checkpoint = 5 def = 0 type = "Owned" Effect to effects.ruleset [effect_owned_bonus] type = "Output_Bonus" value = 1000 reqs = { "type", "name", "range" "Counter", "Owned 5 Turns", "City" "OutputType", "Gold", "Local" } - Launch server and client separately - Connect client to the server - Found a city, and press "Turn Done" five times - Observe on the client how the city is now getting 1000% gold bonus, and majority of it is because of the counter (left mouse button over the "Gold" amount to get the breakdown) - Disconnect and Reconnect the client - Observe how majority of the city's Gold income is now from a source "unknown" to the client (total sum is correct, as server does send that information) --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: (None) Type: Patches Status: Open Priority: 5 - Medium MileStone: 3.2.0 Component: General Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: City counter value updates are sent to client by #45429, but we will need to send also initial values, e.g., when a client reconnects, or game has been loaded from a saved game. Basically when ever full city info gets sent to the client for the first time (note, that if it makes implementation easier; it should be ok to "send" them to the delta protocol layer unconditionally when ever full city info gets sent. Delta protocol would notice itself if there's nothing to update/send) -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/45889 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45889