#48786: specenum generator: Value prefix in header
Open Date: 2023-10-01 22:51
Last Update: 2023-10-02 09:45
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/48786
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48786
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2023-10-02 09:45 Updated by: alienvalkyrie
Comment:
This was something I'd been thinking of from the start (but left out for the sake of minimal initial implementation). The only reservation I have about this is that when searching source files (e.g. git grep or just searching on github) for one of the enum constants, right now you'd still find the corresponding line in the .def at least; if we change this, then once the generated headers are no longer checked into git, you wouldn't be able to find the definition at all if you don't already know where to look.
Then again, the same is already true for all the auxiliary functions; and you would still be able to find the name of the enum type itself.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: 3.3.0
Component: Bootstrap
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Currently each value in specenum generator .def file contains the prefix, e.g., MANUAL_SETTINGS, MANUAL_COMMANDS ...
Should we move the prefix to header part, and define values simply as SETTINGS, COMMANDS ... ?
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/48786
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=48786