#47828: Counters: "User City Counter"
Open Date: 2023-04-10 10:30
Last Update: 2024-01-13 02:55
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/47828
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47828
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2024-01-13 02:55 Updated by: lachu
Comment:
Reply To cazfi
{{{
+void api_counter_increase(lua_State *L,Counter *c, City *city)
}}}
Add space between comma and "Counter". There are several cases like this in the patch
{{{
fc_assert_ret_msg(CB_USER == c->type, "Lua: cannot change non-user counter");
}}}
This should not be an asserting engine (C-code) behavior, as the lua-script can very well trigger it. Should have a regular check, and error message, against illegal lua-script input.
{{{
+#endif
}}}
0001-OSDN-47828-S-awomir-Lach-slawek-lach.art.pl.patch(5KB)
Repair coding style
-> #endif /* FCAPI_GAME_COUNTERS_H */
api_server_counters.c should be added to Meson based build too.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: S3_2 d3f
Component: Scripting API
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
New city counter behavior: "User City Counter".
Depends on #47827
This counter type gets adjusted by new lua methods. E.g. (there might be better API):
- Counter:increase(City)
- Counter:zero(City)
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/47828
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47828