CI: detect broken ruledit comments

• Reporter: kvilhaugsvik
• Owner: kvilhaugsvik
• Type: Patches
• Status: Closed
• Component: CI
• MileStone: 3.1.0 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

So #41631 won't happen again.

Ticket History (3/7 Histories)

2021-02-23 07:47 Updated by: kvilhaugsvik

• New Ticket "CI: detect broken ruledit comments" created

2021-02-23 08:05 Updated by: kvilhaugsvik

Comment

Should ruledit's option Fatal have caught the log_error() call via fatal_assertions?

2021-02-24 22:14 Updated by: kvilhaugsvik

Comment

Reply To kvilhaugsvik

Should ruledit's option Fatal have caught the log_error() call via fatal_assertions?

If not I could extend it to directly exit with a non success exits status when --Fatal (or a new command line option) is specified. That would give us CI coverage.

2021-03-23 07:54 Updated by: cazfi

Comment

log_error() is not fatal nor assertion.

2021-03-23 09:30 Updated by: kvilhaugsvik

• File 0009-ruleup-set-exit-status-based-on-what-happened.patch (File ID: 6316) is attached

2021-03-23 09:31 Updated by: kvilhaugsvik

• Resolution Update from None to Accepted

Comment

Reply To cazfi

log_error() is not fatal nor assertion.

Thank you for the clarification, Marko!

2021-03-25 17:47 Updated by: kvilhaugsvik

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed