civ2 ruleset has two Establish Embassy move costs

• Reporter: cazfi
• Owner: kvilhaugsvik
• Type: Bugs
• Status: Closed
• Component: Rulesets
• MileStone: 3.1.0 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

master civ2 ruleset:

effect_action_success_move_cost_embassy -> Action_Success_Actor_Move_Cost with value 1 for action Establish Embassy

effect_action_success_establish_embassy -> Action_Success_Actor_Move_Cost with value 65535 for action Establish Embassy

Together these make 65536.

Ticket History (3/8 Histories)

2021-03-13 19:57 Updated by: cazfi

• New Ticket "civ2 ruleset has two Establish Embassy move costs" created

2021-03-13 20:14 Updated by: kvilhaugsvik

Comment

Looks like moving two different hard coded move cost to the ruleset on two different occasions. 65535 means "everything".

I could merge them (and probably other rulesets with the same problem) to a single effect with a value of 65535

2021-03-15 06:12 Updated by: kvilhaugsvik

Comment

Is it OK if I take this?

2021-03-15 06:24 Updated by: cazfi

• Owner Update from (None) to kvilhaugsvik

Comment

Reply To kvilhaugsvik

Is it OK if I take this?

That's why I have left it unassigned.

2021-03-15 20:38 Updated by: kvilhaugsvik

• File 0001-Deduplicate-Establish-Embassy-move-costs.patch (File ID: 6273) is attached

2021-03-15 20:38 Updated by: kvilhaugsvik

• Resolution Update from None to Accepted
• Milestone Update from (None) to 3.1.0 (closed)

2021-03-17 13:40 Updated by: kvilhaugsvik

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed

2021-03-19 15:58 Updated by: kvilhaugsvik

Comment

Reply To kvilhaugsvik

Looks like moving two different hard coded move cost to the ruleset on two different occasions.

But a bug because Establish Embassy doesn't result in spy escape. See #41811