Ticket #41796

NoVeteran in effects but not in use

Open Date: 2021-03-17 03:21 Last Update: 2023-09-02 17:35

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
3

Details

The rulesets civ2civ3, classic, experimental, sanndbox and webperimental mention the NoVeteran flag in effects but no unit has the flag.

Ticket History (3/12 Histories)

2021-03-17 03:21 Updated by: kvilhaugsvik
  • New Ticket "NoVeteran in effects but not in use" created
2021-03-20 04:28 Updated by: ihnatus
Comment

Might be, it's a good preparation for the case they ever appear, and we should just omit such requirements when we load the ruleset?

2021-03-20 05:53 Updated by: kvilhaugsvik
Comment

Reply To ihnatus

we should just omit such requirements when we load the ruleset?

No point omitting them. A !present requirement for a flag not in use is always fulfilled.

2021-03-20 06:14 Updated by: cazfi
Comment

Also, we should not omit any rules from the ruleset at loading time - that would leave them out also when saving rules back from ruledit or ruleup. We even have to store some meta-rules that have any effect only at ruleset loading time.

2021-03-20 19:42 Updated by: ihnatus
Comment

Reply To kvilhaugsvik

Reply To ihnatus

we should just omit such requirements when we load the ruleset?

No point omitting them. A !present requirement for a flag not in use is always fulfilled.

Just for a bit of productivity. But per Cazfi, maybe not worth the work.

2023-05-12 13:18 Updated by: cazfi
Comment

Reply To kvilhaugsvik

The rulesets civ2civ3, classic, experimental, sanndbox and webperimental mention the NoVeteran flag in effects but no unit has the flag.

See also #48028 (affects main -> 3.3+)

2023-06-26 20:56 Updated by: cazfi
  • Milestone Update from (None) to 3.0.9 (closed)
  • Component Update from (None) to Rulesets
2023-08-27 13:03 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
Comment

Reply To cazfi

See also #48028 (affects main -> 3.3+)

Thus main is not affected. Patches for S3_0 - S3_2 attached.

2023-09-02 17:35 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login