do_paradrop(): trust the action system

• Reporter: kvilhaugsvik
• Owner: kvilhaugsvik
• Type: Patches
• Status: Closed
• Component: Server
• MileStone: 3.1.0 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Accepted
• File: 2

Details

Trust that the action sent is correct when determining if a city conquest is legal or not in the action performer of the paradrop actions.

Ticket History (3/9 Histories)

2021-03-22 22:44 Updated by: kvilhaugsvik

• New Ticket "do_paradrop(): trust the action system" created

2021-03-22 23:00 Updated by: kvilhaugsvik

• File 0001-do_paradrop-trust-the-action-system.patch (File ID: 6306) is attached

2021-03-22 23:00 Updated by: kvilhaugsvik

• Resolution Update from None to Accepted

2021-03-22 23:05 Updated by: cazfi

Comment

- && pplayers_non_attack(pplayer, plrtile->owner)) { + && !pplayers_allied(pplayer, plrtile->owner) + && !action_has_result(paction, ACTRES_PARADROP_CONQUER)) {

notify_player(pplayer, ptile, E_BAD_COMMAND, ftc_server,

_("Cannot attack unless you declare war first."));

Is that message still accurate?

2021-03-22 23:25 Updated by: kvilhaugsvik

Comment

Reply To cazfi

_("Cannot attack unless you declare war first.")); Is that message still accurate?

Yes, because war is an obligatory hard action requirement.

2021-03-22 23:26 Updated by: kvilhaugsvik

Comment

Wait! Wrong.

2021-03-22 23:56 Updated by: kvilhaugsvik

• File 0001-do_paradrop-trust-the-action-system.patch (File ID: 6311) is attached

2021-03-22 23:56 Updated by: kvilhaugsvik

Comment

v2: catch both conquer and non conquer issues

(Edited, 2021-03-23 00:02 Updated by: kvilhaugsvik)

2021-03-24 19:40 Updated by: kvilhaugsvik

• Status Update from Open to Closed