capability.c function headers to say 'TRUE' instead of 'true'

• Reporter: cazfi
• Owner: cazfi
• Type: Patches
• Status: Closed
• Component: General
• MileStone: 3.1.0 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

When referring to value of type bool, capability.c function headers should say 'TRUE' instead of 'true'

Ticket History (3/6 Histories)

2021-05-09 20:54 Updated by: cazfi

• New Ticket "capability.c function headers to say 'TRUE' instead of 'true'" created

2022-07-19 05:52 Updated by: dark-ether

• File 0001-change-function-explaining-comments-to-contain-TRUE-.patch (File ID: 9848) is attached

2022-07-19 05:55 Updated by: dark-ether

Comment

i was looking on old tickets to see if any interested me and this seemed too easy to just leave undone.

I assume you did this ticket to generate discussion, in my opinion we should be consistent with style and leave all function headers in all caps when they refer to the macros

2022-07-19 15:44 Updated by: cazfi

Comment

Reply To dark-ether

in my opinion we should be consistent with style and leave all function headers in all caps when they refer to the macros

It's not only a style issue, but the fact that 'TRUE' (the macro) is not the same thing as boolean concept (or C++ / newer C boolean value) 'true'.

Typically I open this kind of tickets when I'm working on something else that I don't want to interrupt (maybe also having modifications for that work in my source tree) and don't want to forget what I've noticed.

Likely there's similar issues in other headers too.

2022-07-25 09:30 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted
• Milestone Update from (None) to 3.1.0 (closed)

Comment

The patch does not apply to S3_0. Just targeting the ticket to S3_1 instead of waiting for separate S3_0 patch.

2022-07-27 07:24 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed