Ticket #43059

ruleset.c comments about global_unit_options

Open Date: 2021-10-18 03:20 Last Update: 2022-08-01 18:34

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

There is no global_unit_options section any more in master. Grep reveals that there still is some comments in ruleset.c referring to it. Maybe need changing in older branches too, to reflect the fact that the section will disappear in 3.2.

Ticket History (3/10 Histories)

2021-10-18 03:20 Updated by: cazfi
  • New Ticket "ruleset.c comments about global_unit_options" created
2022-01-27 12:55 Updated by: cazfi
  • Milestone Update from (None) to 3.0.1 (closed)
  • Component Update from (None) to Server
2022-03-13 02:09 Updated by: dark-ether
Comment

i could just remove the comments and submit a patch, but what are the plans regarding those options? they are things that are unit related,so they make sense to be in a section specifically about units, should nothing be done about them and just remove the comments? or should i move them to units.ruleset control section?

2022-03-13 04:37 Updated by: cazfi
Comment

They have something to do with units, yes, but IMHO they are still more about civstyle than about units (belong to game.ruleset more than to units.ruleset). At this point I would just remove the comments.

2022-04-09 04:14 Updated by: cazfi
Comment

Reply To dark-ether

i could just remove the comments and submit a patch

Will you?

2022-04-13 20:16 Updated by: cazfi
2022-06-11 21:50 Updated by: cazfi
2022-07-25 04:14 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
2022-08-01 18:34 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login