action_prob_pre_action_dice_roll() checking action possibility for wrong player

• Reporter: cazfi
• Owner: kvilhaugsvik
• Type: Bugs
• Status: Closed
• Component: General
• MileStone: 3.1.0 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

It seems wrong to me that action_prob_pre_action_dice_roll() checks "is_effect_val_known(EFT_ACTION_ODDS_PCT, act_player, tgt_player, tgt_player, ...". If I understand the functions right, the first player argument 'act_player' is who gets the information. Second and third ones are the the parties of the incident. So the call is like 'tgt_player' attacking 'tgt_player'. Should be 'act_player' attacking 'tgt_player', I think.

Ticket History (3/5 Histories)

2021-11-06 22:05 Updated by: cazfi

• New Ticket "action_prob_pre_action_dice_roll() checking action possibility for wrong player" created

2021-11-07 00:06 Updated by: kvilhaugsvik

Comment

I agree that it looks that way. I have sent the author of that code an email to check if we have missed something.

(Edited, 2021-11-07 00:07 Updated by: kvilhaugsvik)

2021-11-08 15:39 Updated by: kvilhaugsvik

• File 0001-Check-effect-value-known-for-the-correct-player.patch (File ID: 7909) is attached

2021-11-08 15:41 Updated by: kvilhaugsvik

• Owner Update from (None) to kvilhaugsvik
• Resolution Update from None to Accepted
• Milestone Update from (None) to 3.1.0 (closed)

Comment

Reply To kvilhaugsvik

I have sent the author of that code an email to check if we have missed something.

We didn't miss something.

2021-11-12 18:34 Updated by: kvilhaugsvik

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed