Make diplomatic battle veterancy gaining to respect combat_odds_scaled_veterancy

• Reporter: cazfi
• Owner: cazfi
• Type: Patches
• Status: Closed
• Component: Server
• MileStone: 3.1.0 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

When implementing combat_odds_scaled_veterancy ( https://www.hostedredmine.com/issues/804347 ) for regular combat, passing 100% chance as a parameter from any diplomatic battle seemed quite wrong. If challenge affects veterancy odds in normal combat, so should it in diplomatic one.

As part of #43200, this has also been posted to http://forum.freeciv.org/f/viewtopic.php?f=14&t=92051

Ticket History (3/8 Histories)

2021-11-10 13:28 Updated by: cazfi

• New Ticket "Make diplomatic battle veterancy gaining to respect combat_odds_scaled_veterancy" created

2021-11-20 14:12 Updated by: cazfi

• File 0037-Make-diplomat-battle-veterancy-gaining-respect-comba.patch (File ID: 7994) is attached

2021-11-20 14:12 Updated by: cazfi

• Resolution Update from None to Accepted

2021-11-20 14:14 Updated by: cazfi

• Details Updated

2021-11-20 16:55 Updated by: cazfi

• Resolution Update from Accepted to None

Comment

Unlike for normal battle, the current patch does not scale the base chance up by multiplying to by 2 -> to make it 100 on the typical case where both sides have 50% chance of winning. 100 is the value that one gets when combat_odds_scaled_veterancy is disabled. This needs to be fixed.

2021-11-21 05:15 Updated by: cazfi

• File 0033-Make-diplomat-battle-veterancy-gaining-respect-comba.patch (File ID: 8002) is attached

2021-11-21 05:15 Updated by: cazfi

• Resolution Update from None to Accepted

Comment

New version that has the scaling correctly.

2021-12-06 01:46 Updated by: cazfi

• Status Update from Open to Closed
• Owner Update from (None) to cazfi
• Resolution Update from Accepted to Fixed