Lua: remove_extra() not working
ddeanbrown in #43584:
Tested with RC1, assert errors are gone, but remove_extra() is not working.
Also tried connecting to "turn_begin" signal and running on turn 1, instead of connecting to "map_generated" signal, and saw same problem, so maybe remove_extra() got broken.
so maybe remove_extra() got broken.
I think it has been broken on S3_0 (for resources) either always or for a long time (might have gotten broken when their reappearance in case of terrain changing back to one supporting them was fixed) - and in earlier branches resources were not even considered extras.
Fix *seems* simple, but kind of risky in that it might break something else, and more critical - this might be something that we don't want to push in before 3.0.0 even with RC2 route, but want to expose to testing for entire 3.0.1 cycle. While it's annoying that it breaks that ruleset mentioned in the forums, it's not a regression either (it was not possible to remove resources in 2.6)
I'll submit the fix soon anyway, so we do have it available whatever we decide.
Reply To cazfi
I'll submit the fix soon anyway
it's not a regression either (it was not possible to remove resources in 2.6)
Targeted to 3.0.0-RC2