generate_packets.py: Context manager for lazy_overwrite

• Reporter: alienvalkyrie
• Owner: alienvalkyrie
• Type: Patches
• Status: Closed
• Component: Bootstrap
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details Reply

Part of #43927. Pack lazy overwrite code into a context manager and use it in fc_open() if lazy_overwrite is enabled.

Ticket History (3/6 Histories)

2022-02-21 04:11 Updated by: alienvalkyrie

• New Ticket "generate_packets.py: Context manager for lazy_overwrite" created

2022-02-21 04:17 Updated by: alienvalkyrie

Comment Reply

I think it would also be sensible to enable lazy_overwrite; while refactoring the script in particular, but also in general – no need to rebuild the entire code base when the header didn't even actually change.

2022-02-21 04:42 Updated by: alienvalkyrie

• File 0008-generate_packets.py-Unify-code-for-lazily-overwritin.patch (File ID: 8605) is attached

2022-02-21 04:44 Updated by: alienvalkyrie

• Resolution Update from None to Accepted

Comment Reply

Reply To alienvalkyrie

I think it would also be sensible to enable lazy_overwrite

Did just that.

2022-02-22 21:11 Updated by: alienvalkyrie

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed

2022-03-01 18:04 Updated by: cazfi

Comment Reply

I think this is causing #43995 (discussion to continue on that ticket)