cityresult_fill() fetch both advisor data ('adv') and ai data ('ai'). The only use for the ai data is that its existence is asserted. Event that assert should probably be checking advisor data instead.
All this has likely been introduced when advisor data was first split from ai data, and some functions really needed both while others only one of them. Because the assert it has seemed like the ai data is needed here.
cityresult_fill() fetch both advisor data ('adv') and ai data ('ai'). The only use for the ai data is that its existence is asserted. Event that assert should probably be checking advisor data instead.
All this has likely been introduced when advisor data was first split from ai data, and some functions really needed both while others only one of them. Because the assert it has seemed like the ai data is needed here.