.mpdl format: Allow baseURL to end to '/'

• Reporter: cazfi
• Owner: cazfi
• Type: Patches
• Status: Closed
• Component: Modpack Installer
• MileStone: S3_1 d3f (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

Modpack installer forms the final URL by "baseURL + '/' + path". That means that baseURL is not allowed to contain the '/' as it would duplicate, leading to trouble as I just witnessed debugging problems on a modpack that was installed with baseURL "./"

We definitely be smarter about that, and check if baseURL already ends to '/', and not duplicate it in that case.

This should be the case both with paths relative to modpack list, and paths relative to .mpdl.

Ticket History (3/5 Histories)

2022-04-09 21:05 Updated by: cazfi

• New Ticket ".mpdl format: Allow baseURL to end to '/'" created

2022-04-10 12:50 Updated by: cazfi

• File 0047-fcmp-Allow-baseURL-to-end-to.patch (File ID: 8974) is attached

2022-04-10 12:51 Updated by: cazfi

• File 0021-README.modpack_installer-Add-note-about-baseURL-and-.patch (File ID: 8975) is attached

2022-04-10 12:52 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

Comment

S3_0 (d3f branch) patch just adds warning about the format to README.modpack_installer.

2022-04-21 08:06 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed