Climate change does not cancel further orders of the units

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Server
• MileStone: 3.0.2 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

climate_change() does check if current activity for the units in changed tiles can continue, and aborts it if not. That should be a call to full handling in unit_activities_cancel_all_illegal() - that includes aborting all of the orders sequence, if the activity was part of such.

Ticket History (3/6 Histories)

2022-04-14 15:18 Updated by: cazfi

• New Ticket "Climate change does not cancel further orders of the units" created

2022-04-15 00:51 Updated by: cazfi

• File 0046-Cancel-also-unit-orders-when-the-activity-has-turned.patch (File ID: 9009) is attached

2022-04-15 00:51 Updated by: cazfi

• File 0020-Cancel-also-unit-orders-when-the-activity-has-turned.patch (File ID: 9010) is attached

2022-04-15 00:53 Updated by: cazfi

Comment

The climate_change() case was far from the only one where activity-turned-illegal handling was lacking. Attached patches reworks them all.

2022-04-15 00:54 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted
• Milestone Update from (None) to 3.0.2 (closed)

2022-04-25 04:50 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed