Qt: option_dialog::add_option() references through NULL widget pointer

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Qt-client
• MileStone: 3.0.2 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

Originally from clang static analyzer report.

option_dialog::add_option() initialized 'widget' as NULL. In most cases it then gets set to a real value, but not always. Part of the following code is within "if (widget != NULL)", but even outside that block there's some references through 'widget'.

I've not tested it yet, but this seems something that can cause a client crash.

Ticket History (3/4 Histories)

2022-04-29 13:58 Updated by: cazfi

• New Ticket "Qt: option_dialog::add_option() references through NULL widget pointer" created

2022-05-01 23:09 Updated by: cazfi

• File 0058-Qt-Avoid-option_dialog-add_option-using-NULL-object-.patch (File ID: 9136) is attached

2022-05-01 23:09 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted
• Milestone Update from (None) to 3.0.2 (closed)

Comment

Will push even to S2_6.

2022-05-10 00:51 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed