Json protocol dio_put_*() to return int

• Reporter: cazfi
• Owner: cazfi
• Type: Patches
• Status: Closed
• Component: General
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

Split from https://www.hostedredmine.com/issues/745593 and continuation to #44458

Turn dio_put_*() return value to int, though all the functions can return just 0 at this point. Port parts of generate_packets.py changes from https://www.hostedredmine.com/issues/745593 that the API change allows.

Ticket History (3/8 Histories)

2022-06-12 03:34 Updated by: cazfi

• New Ticket "Json protocol dio_put_*() to return int" created

2022-06-12 05:14 Updated by: cazfi

• File 0041-json-protocol-Make-return-value-of-dio_put_-an-int.patch (File ID: 9467) is attached

2022-06-12 05:14 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2022-06-12 21:13 Updated by: cazfi

• Resolution Update from Accepted to None

Comment

clang gives a bunch of "variable 'e' set but not used" -warnings.

2022-06-13 00:36 Updated by: cazfi

Comment

Reply To cazfi

clang gives a bunch of "variable 'e' set but not used" -warnings.

These indicate real bug - the "use" would be checking the error value, and certainly it should be made when ever error might have been set.

2022-06-13 01:20 Updated by: cazfi

• File 0030-json-protocol-Make-return-value-of-dio_put_-an-int.patch (File ID: 9476) is attached

2022-06-13 01:20 Updated by: cazfi

• Resolution Update from None to Accepted

Comment

Reply To cazfi

the "use" would be checking the error value, and certainly it should be made when ever error might have been set.

Fixed.

2022-06-24 21:24 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed