sdl2: SDL_GetColorKey() assumed to success

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: SDL2-client
• MileStone: 3.0.3 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

sdl2-client get_smaller_surface_rect() calls SDL_GetColorKey(), assumes it success, and goes on using the key. The problem is, we don't set the key for most surfaces, and often that call actually fails.

Ticket History (3/8 Histories)

2022-06-21 18:54 Updated by: cazfi

• New Ticket "sdl2: SDL_GetColorKey() assumed to succes" created

2022-06-21 20:45 Updated by: cazfi

Comment

This affects, e.g., #44891

2022-06-21 20:47 Updated by: cazfi

• Milestone Update from (None) to 3.0.3 (closed)

2022-06-22 02:04 Updated by: cazfi

• File 0059-sdl2-Search-icon-borders-by-alpha-when-no-colorkey-a.patch (File ID: 9580) is attached

2022-06-22 02:04 Updated by: cazfi

• File 0026-sdl2-Search-icon-borders-by-alpha-when-no-colorkey-a.patch (File ID: 9581) is attached

2022-06-22 02:05 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

Comment

Going to push S3_0 patch to S2_6 too

2022-06-22 02:08 Updated by: cazfi

• Summary Updated

2022-06-27 11:03 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed