sdl2: popup_races_dialog() surface leak

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: SDL2-client
• MileStone: 3.0.3 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 4

Details

pTmp_Surf_zoomed created at S3_0 sdl2-client dialog.c:3080 is never freed.

Ticket History (3/8 Histories)

2022-06-21 18:56 Updated by: cazfi

• New Ticket "sdl2: popup_races_dialog() surface leak" created

2022-06-25 03:23 Updated by: cazfi

• File 0062-sdl2-Fix-nation-selection-dialog-surface-leak.patch (File ID: 9608) is attached

2022-06-25 03:23 Updated by: cazfi

• File 0029-sdl2-Fix-nation-selection-dialog-surface-leak.patch (File ID: 9609) is attached

2022-06-25 03:23 Updated by: cazfi

• File 0019-sdl-2-Fix-nation-selection-dialog-surface-leak.patch (File ID: 9610) is attached

2022-06-25 03:24 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

Comment

Separate patch attached even for S2_6, for fixing the issue in sdl-client too.

2022-07-03 12:03 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed

2022-07-08 09:23 Updated by: cazfi

• File 0016-Revert-sdl-client-part-of-Fix-nation-selection-dialo.patch (File ID: 9765) is attached

2022-07-08 09:23 Updated by: cazfi

Comment

Reply To cazfi

Separate patch attached even for S2_6, for fixing the issue in sdl-client too.

Touching sdl-client was probably a mistake. The utility functions used differ between sdl2-client and sdl-client, so it's likely that this just breaks things in sdl-client.

Will revert sdl-client part from S2_6.