Prefer signal.h over sys/signal.h

• Reporter: cazfi
• Owner: cazfi
• Type: Patches
• Status: Closed
• Component: General
• MileStone: 3.0.6 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

netintf.c includes sys/signal.h instead of signal.h, though that is far from recommendations. I believe that reason is ancient - some *nix where freeciv was developed in the 90's had some issue with signal.h (not yet standardised to that over sys/signal.h). Likely there's no reason to keep it that way 202x.

Ticket History (3/7 Histories)

2022-07-04 02:46 Updated by: cazfi

• New Ticket "Prefer signal.h over sys/signal.h" created

2022-07-04 02:50 Updated by: cazfi

• File 0061-Prefer-signal.h-over-sys-signal.h.patch (File ID: 9700) is attached

2022-07-04 02:50 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2022-07-15 00:47 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed

2023-01-17 10:23 Updated by: cazfi

• File 0006-Prefer-signal.h-over-sys-signal.h.patch (File ID: 11383) is attached

2023-01-17 10:24 Updated by: cazfi

• Status Update from Closed to Open
• Resolution Update from Fixed to Accepted
• Milestone Update from 3.1.0 (closed) to 3.0.6 (closed)

Comment

This issue affects void linux / musl build also in older branches - let's backport the fix. Old patch applies to S3_0. For S2_6 a new patch has been attached.

2023-01-19 04:08 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed