Ticket #45084

Output_Penalty_Tile description in README.effects is incomplete

Open Date: 2022-07-11 10:00 Last Update: 2022-10-07 09:12

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
3

Details

3.0.1, most rulesets.

In README.effects, the description text for Output_Penalty_Tile says -

"When a tile yields more output than amount, it gets a penalty of -1."

In the auto-generated help in the governments section for Anarchy and Despotism, it says -

"Each worked tile that gives more than 2 Food, Shield, or Trade will suffer a -1 penalty, unless the city working it is celebrating. (Cities below size 3 will not celebrate.)"

Output_Penalty_Tile description in README.effects should say something about the celebrating exception. I updated the wiki page "Editing Effects".

Ticket History (3/16 Histories)

2022-07-11 10:00 Updated by: ddeanbrown
  • New Ticket "Output_Penalty_Tile description in README.effects is incomplete" created
2022-07-14 21:19 Updated by: cazfi
Comment

Also, in future versions (maybe already in 3.2) this certainly should go to the ruleset, listed just as a requirement for the effect.

2022-07-14 21:20 Updated by: cazfi
  • Component Update from General to Documentation
2022-07-26 03:52 Updated by: ddeanbrown
  • File Output_Penalty_Tile description in README.effects.patch (File ID: 9937) is attached
2022-07-26 04:04 Updated by: ddeanbrown
  • File Output_Penalty_Tile description in README.effects.patch (File ID: 9937) is deleted
2022-07-26 04:07 Updated by: ddeanbrown
Comment

This patch works for S3_0 & S3_1. Maybe want it in S2_6 and/or S2_6_2? If so will need another patch because this one fails there.

Agree 3.2/master is a different situation with the new "CityStatus" requirement value "Celebration". Looks to me like we need another ticket for that.

2022-07-26 07:44 Updated by: ddeanbrown
Comment

created new ticket #45236 "Output_Penalty_Tile changes for 3.2"

2022-08-06 22:51 Updated by: cazfi
Comment

Please don't claim that celebratesize is (always) 3, like it was hardcoded.

2022-08-06 22:52 Updated by: cazfi
2022-08-23 23:13 Updated by: cazfi
Comment

Reply To cazfi

Please don't claim that celebratesize is (always) 3, like it was hardcoded.

Will you make an updated version?

2022-10-01 23:30 Updated by: cazfi
Comment

Thought I'd update this myself, to still get it in 3.0.4, but I'm not sure if one should change it to refer to 'ruleset defined celebrate_size_limit' instead of '3', should we just leave the entire sentence out, or should we add similar sentence also to all other effects which applies only to celebrating cities or only to cities not celebrating.

2022-10-05 11:23 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
Comment

Reply To cazfi

I'm not sure if one should change it to refer to 'ruleset defined celebrate_size_limit' instead of '3', should we just leave the entire sentence out, or should we add similar sentence also to all other effects which applies only to celebrating cities or only to cities not celebrating.

Attached patches just leave the sentence out. At least this is an improvement already, without it. With the delay of 3.0.4 this should still make it to it.

2022-10-07 09:12 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login