technology with a Never value in req1 and 2 will generate many errors

• Reporter: dark-ether
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Server
• MileStone: 3.0.7 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 5

Details

if you have a tech with Never as the value of req1 and req2 it will generate tens of errors per turn. the errors have the following form

1: in research_invention_state() [research.c::620]: assertion '((void *)0) != valid_advance_by_number(tech)' failed.

1: Please report this message at https://osdn.net/projects/freeciv/ticket/

Ticket History (3/19 Histories)

2022-07-16 20:04 Updated by: dark-ether

• New Ticket "technology with a Never value in req1 or 2 will generate many errors" created

2022-07-16 20:05 Updated by: dark-ether

• File techs.ruleset (File ID: 9818) is attached

2022-07-16 20:06 Updated by: dark-ether

• Details Updated
• Summary Updated

2022-07-16 20:07 Updated by: dark-ether

• Details Updated

2022-07-16 20:16 Updated by: cazfi

Comment

Backtrace seems to always show research_invention_state() -> maybe something to fix in it.

Though I don't know what support of "Never" requirement for techs is needed any more. Should we just get rid of it in master (d3f branches still need to be fixed)?

2022-07-16 20:47 Updated by: cazfi

Comment

Reply To cazfi

Though I don't know what support of "Never" requirement for techs is needed any more.

Ah, removal of a tech without breaking compatibility with existing savegames that refer to such tech likely works with this. Should reconsider also #45021 because of this.

2022-07-20 16:51 Updated by: cazfi

• Milestone Update from (None) to 3.0.3 (closed)

2022-07-20 16:51 Updated by: cazfi

• Component Update from Rulesets to Server

2022-08-05 09:01 Updated by: cazfi

• Milestone Update from 3.0.3 (closed) to 3.0.4 (closed)

2022-10-07 09:31 Updated by: cazfi

• Milestone Update from 3.0.4 (closed) to 3.0.5 (closed)

2022-12-07 02:26 Updated by: cazfi

• Milestone Update from 3.0.5 (closed) to 3.0.6 (closed)

2023-01-18 04:41 Updated by: cazfi

• File 0034-Fix-errors-because-of-Never-reachable-techs.patch (File ID: 11391) is attached

2023-01-18 04:42 Updated by: cazfi

• File 0035-Fix-errors-because-of-Never-reachable-techs.patch (File ID: 11392) is attached

2023-01-18 04:42 Updated by: cazfi

• File 0017-Fix-errors-because-of-Never-reachable-techs.patch (File ID: 11393) is attached

2023-01-18 04:42 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

2023-01-19 02:37 Updated by: cazfi

• Milestone Update from 3.0.6 (closed) to 3.0.7 (closed)

Comment

This causes #46544 breakage. Even though I have almost ready fix, this is a bit risky -> keep in testing for a full minor release cycle 3.0.6 -> 3.0.7

2023-03-04 14:22 Updated by: cazfi

• File 0015-Fix-errors-because-of-Never-reachable-techs.patch (File ID: 11762) is attached

2023-03-04 14:23 Updated by: cazfi

Comment

Rebased main/S3_2 patch attached. S3_1 and S3_0 patches need no changes.

2023-03-07 05:08 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed