Failing "punit->homecity == pcity->id" asserts for NoHome units

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Server
• MileStone: 3.1.0 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 3

Details

Overzealous asserts in place_unit() and check_city_good() fail for NoHome units.

Ticket History (3/8 Histories)

2022-07-23 15:06 Updated by: cazfi

• New Ticket "Failing "punit->homecity == pcity->id" asserts for NoHome units" created

2022-07-23 15:14 Updated by: cazfi

• File 0056-Fix-overzealous-asserts-against-NoHome-units.patch (File ID: 9900) is attached

2022-07-23 15:15 Updated by: cazfi

• File 0021-Fix-overzealous-asserts-against-NoHome-units.patch (File ID: 9901) is attached

2022-07-23 15:15 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted
• Milestone Update from (None) to 3.0.3 (closed)

Comment

S3_0 version to be applied to S2_6 too

2022-07-24 11:52 Updated by: cazfi

• Resolution Update from Accepted to None
• Milestone Update from 3.0.3 (closed) to (None)

Comment

Maybe those asserts are not overzealous, but they have been detecting an actual bug. They are in the context of units in city.units_supported, so there should NOT be any NoHome units there.

2022-07-25 02:22 Updated by: cazfi

• File 0044-place_unit-Do-not-add-NoHome-units-to-city-s-units_s.patch (File ID: 9912) is attached

2022-07-25 02:22 Updated by: cazfi

• Resolution Update from None to Accepted
• Milestone Update from (None) to 3.1.0 (closed)

Comment

Actual bugfix attached. master & S3_1 affected.

2022-07-29 17:58 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed