generate_packets.py: Move key field "unfill" into type code

• Reporter: alienvalkyrie
• Owner: alienvalkyrie
• Type: Patches
• Status: Closed
• Component: Bootstrap
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

Part of #45206. Introduce a new Field.get_unfill() method, which calls a FieldType.get_code_unfill() method that stores field values in local variables, for use in Variant.get_delta_receive_body().

Ticket History (3/4 Histories)

2022-07-25 02:47 Updated by: alienvalkyrie

• New Ticket "generate_packets.py: Move key field "unfill" into type code" created

2022-07-25 06:44 Updated by: alienvalkyrie

• File 0013-generate_packets.py-Move-field-unfill-code-into-type.patch (File ID: 9928) is attached

2022-07-25 06:45 Updated by: alienvalkyrie

• Resolution Update from None to Accepted

Comment

I'm not completely happy with this patch (struct fields being passed by-reference to handle/dsend make reusing fill difficult here); but it works fine for all current use cases, and I'll have to go over all the fill stuff again anyway.

2022-07-26 21:44 Updated by: alienvalkyrie

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed