Unsigned max_trade_routes() return value

• Reporter: cazfi
• Owner: cazfi
• Type: Patches
• Status: Closed
• Component: General
• MileStone: 3.0.4 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details Reply

max_trade_routes() never returns a negative value. Its return type should reflect this.

I think that some clang analyzer warnings we're getting result only from the fact that compiler considers the possibility that a value got from max_trade_routes() is negative.

Ticket History (3/4 Histories)

2022-08-07 00:49 Updated by: cazfi

• New Ticket "Unsigned max_trade_routes() return value" created

2022-08-21 18:08 Updated by: cazfi

• File 0041-Make-max_trade_routes-return-type-unsigned.patch (File ID: 10121) is attached

2022-08-21 18:08 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted
• Milestone Update from (None) to 3.0.4 (closed)

2022-08-29 18:07 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed